feat: implement flashblock sync over p2p #288
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
please test with load with contender just to make sure there's no regression in the caching (notably the latencies for get payload, new payload etc are not affected under load) |
SozinM
reviewed
Oct 27, 2025
crates/p2p/src/outgoing.rs
Outdated
| } | ||
| } | ||
| debug!( | ||
| info!( |
SozinM
reviewed
Oct 27, 2025
crates/p2p/src/lib.rs
Outdated
| .. | ||
| } => { | ||
| debug!("connection closed with peer {peer_id}: {cause:?}"); | ||
| info!("connection closed with peer {peer_id}: {cause:?}"); |
SozinM
reviewed
Oct 27, 2025
crates/p2p/src/behaviour.rs
Outdated
| continue; | ||
| } | ||
|
|
||
| tracing::info!("mDNS discovered peer {peer_id} at {multiaddr}"); |
There was a problem hiding this comment.
Pull Request Overview
This PR implements peer-to-peer synchronization and execution of flashblocks, allowing builder nodes to receive and execute flashblocks from other builders in addition to building their own.
Key changes:
- Added flashblock execution logic for synced blocks with validation against expected block hashes
- Enhanced P2P behavior to automatically dial discovered mDNS peers and prevent duplicate connections
- Added new metrics to distinguish between built and synced flashblocks
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| crates/p2p/src/outgoing.rs | Enhanced error handling for message broadcasting and changed logging level from debug to info |
| crates/p2p/src/lib.rs | Added automatic dialing of mDNS discovered peers and updated event handling to pass swarm reference |
| crates/p2p/src/behaviour.rs | Modified mDNS event handling to dial discovered peers if not already connected |
| crates/op-rbuilder/src/tests/flashblocks.rs | Reformatted test configuration structs (whitespace changes only) |
| crates/op-rbuilder/src/metrics.rs | Added metrics for synced blocks and separated invalid block counters for built vs synced blocks |
| crates/op-rbuilder/src/builders/flashblocks/service.rs | Created syncer context and integrated it with payload handler |
| crates/op-rbuilder/src/builders/flashblocks/payload_handler.rs | Implemented complete flashblock execution and validation logic for synced payloads |
| crates/op-rbuilder/src/builders/flashblocks/payload.rs | Updated metrics initialization and reference to use shared instance |
| crates/op-rbuilder/src/builders/flashblocks/mod.rs | Added ctx module declaration |
| crates/op-rbuilder/src/builders/flashblocks/ctx.rs | New file defining syncer context for flashblock execution |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.
Comments suppressed due to low confidence (1)
crates/op-rbuilder/src/builders/flashblocks/payload_handler.rs:1
- The TODO comment indicates uncertainty about cancellation token usage. If the token is truly unused due to reth's task_executor, consider documenting why it's still being created and passed through the system, or evaluate if it should be removed.
use crate::{
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
instructions for local testing with builder-playground, 1 builder building and 1 builder syncing:
cd builder-playground && git checkout noot/multi-buildercd op-rbuilder && git checkout noot/p2p-sync && cargo builddocker logs devnet-op-rbuilder-sync-only-1 -fyou should see logs showing that the nodes connected and that flashblocks are syncing and successfully executing and being added to the canonical chain:
💡 Motivation and Context
--- see #275
✅ I have completed the following steps:
make lintmake test